search

legacysurvey / legacypipe

Image reduction pipeline for the DESI Legacy Imaging Surveys, using the Tractor framework
BSD 3-Clause "New" or "Revised" License
37 stars 22 forks source link

Set lower limit n=0.5 for Sersic fits #498

Closed djschlegel closed 4 years ago

djschlegel commented 4 years ago

The dr9d test reductions allowed Sersic indices as low as n=0.29. Set this lower limit to n=0.5 instead (which is a gaussian profile), and flag when that fitting limit is hit.

dstndstn commented 4 years ago

Do you want to make the limit something like 0.45, so that 0.5 is valid?

On Mon, Feb 3, 2020 at 10:55 AM David Schlegel notifications@github.com wrote:

Assigned #498 https://github.com/legacysurvey/legacypipe/issues/498 to @dstndstn https://github.com/dstndstn.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/legacysurvey/legacypipe/issues/498?email_source=notifications&email_token=AAIEH7NZDD3X4ZO72TUQSDTRBBK7LA5CNFSM4KPJNKEKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWMAR4KQ#event-3003194922, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIEH7JNICOWZ63HYVU2RJLRBBK7LANCNFSM4KPJNKEA .

moustakas commented 4 years ago

I would make n=0.5 the minimum and flag the fits that run up against that value.

moustakas commented 4 years ago

This change was implemented as in currently in master. (The bigger issue is that most SER fits are crap!)