legacysurvey / obiwan

Inject artificial sources and rerun the pipeline to understand systematics
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

add WISE #16

Open kaylanb opened 6 years ago

kaylanb commented 6 years ago

This is an issue for MUCH later, but it looks like target selection will use WISE for ELGs, so we'll probably need to add fakes to the WISE imaging.


Hi Dustin,

I want to add fake sources to wise data for Obiwan. Aaron has a nice module for doing this, but I'm not sure where to plug it into legacypipe. Does tractor or astrometry.net actually do the forced photom?

I've always assumed without looking that wise forced photometry, e.g. printing something like Photometering WISE band 2 to the log files happens in a module in legacypipe/py/legacpipe/ , but I couldn't find anything with grep "Photometering WISE" legacypipe/*.py

It's here, https://github.com/dstndstn/tractor/blob/master/wise/forcedphot.py#L49 called from here, https://github.com/legacysurvey/legacypipe/blob/master/py/legacypipe/runbrick.py#L2258 so you might want to jump in here, after the 'tim' is created, https://github.com/dstndstn/tractor/blob/master/wise/forcedphot.py#L64

For decam, Obiwan has a class SimImage that inherits DecamImage and adds to the "tim" returned by "get_tractor_image" function from and adds to it. For wise, everything looks like separate functions ("unwise_forcedphot"and "get_unwise_tractor_image") so how hard would it be or how badly would it break things if we turned the "unwise_forcedphot" function into a Class having methods "get_tractor_image", etc?

(err, tractor dr5.2, I mean)

moustakas commented 6 years ago

Please keep me in the loop on this. I have similar requests for the central galaxy / large-galaxy work I'm doing.

That said, it's not at all clear that we'll be using unWISE for ELG target selection, unless there's work I'm not aware of!