Rename periods to delimiters

legalforce-research / easy-segmenter

Fast and customizable rule-based sentence segmenter (WIP)

Apache License 2.0

2 stars 0 forks source link

Rename periods to delimiters #20

Closed kampersanda closed 2 years ago

kampersanda commented 2 years ago

This PR renames the term "period" into "delimiter", following the issue https://github.com/legalforce-research/easy-segmenter/issues/16.

~Also, it contains the following minor updates:~

~Remove the term "easy-to-use" from comments in segmenter.rs.~
~Update the doc comment in lib.rs following the current README.~

Add: The strike-through updates are separated to https://github.com/legalforce-research/easy-segmenter/pull/22.

tetsuok commented 2 years ago

Would you create a separate PR on comment updates? This PR includes different types of changes: renaming APIs and comment updates (unrelated to API renames). Mixing different types of changes into a same commit is antipattern. It is getting difficult to review PRs and to revert the commit afterwards.

kampersanda commented 2 years ago

@tetsuok

Okay. I created another PR, https://github.com/legalforce-research/easy-segmenter/pull/22, for the updates other than the renaming. Could you review it before this PR?

tetsuok commented 2 years ago

@kampersanda sure.

kampersanda commented 2 years ago

@tetsuok I merged the main branch, and this PR contains only changes of renaming. Could you review it?