search

legalforce-research / easy-segmenter

Fast and customizable rule-based sentence segmenter (WIP)
Apache License 2.0
2 stars 0 forks source link

Format Cargo.toml #24

Closed kampersanda closed 2 years ago

kampersanda commented 2 years ago

This PR formats files of Cargo.toml using a formatter.

tetsuok commented 2 years ago

@kampersanda Is it possible to add a step to run the formatter in GitHub Actions, (either this PR or in a separate PR)?

kampersanda commented 2 years ago

@tetsuok It seems to be possible to achieve that with https://github.com/stefanzweifel/git-auto-commit-action. I'll create another PR to update the CI setting (although this may take some time as I'm unfamiliar with GitHub Actions). If the PR is created, then this PR will close.

tetsuok commented 2 years ago

@kampersanda That solves a different problem. Would you answer the following questions?

kampersanda commented 2 years ago

@tetsuok

Which formatter did you use actually?

I used Taplo with the default setting.

How did you format Cargo.toml exactly?

I performed the formatting through its VS-code plugin named Even Better TOML. (more exactly, with "Format On Save" option)

tetsuok commented 2 years ago

@kampersanda Thanks for the info. We could add a new CI job in rust.yml to run the tool from CLI, because Taplo provides the official Docker image on Docker Hub, which means we could run the tool like docker run tamasfe/taplo format in the environment where Docker is installed. I can help that configuration, but if you want to work on it by yourself, that's completely fine. That's a good example to learn GitHub Actions.

kampersanda commented 2 years ago

@tetsuok Thank you for the advice! I will try to implement it to learn GitHub Actions!