search

legalthings / angular-signature

HTML5 canvas based smooth signature drawing as angularJS directive (http://szimek.github.io/signature_pad/)
MIT License
105 stars 91 forks source link

updateModel is not invoked when using touch device (wrong PR) #20

Closed ahmehri closed 8 years ago

ahmehri commented 8 years ago

updateModel function is not invoked when touch device is used, this is because this function is invoked only when mouseup event is fired (only ng-mouseup directive is used), the fix was to listen to the touchend event and invoke updateModel when the event is fired.

jasny commented 8 years ago

@ahmehri Thanks for your PR. However please do not mix a bug fix and a new feature in a single PR.

Could you create a PR for the touch device fix and another one for the notifyDrawing feature? Also please squash your commits.

ahmehri commented 8 years ago

@jasny sorry you're right, I did that by mistake (using my master branch instead of the appropriate one). I'll create the two different PRs and fix this.

ahmehri commented 8 years ago

@jasny the correct PR related to the bug fix have been created (#26).