Open saurabh-jtg opened 7 years ago
The minimum angular version mentioned in bower.json is 1.3 while there are two usages of $timeout() (at https://github.com/legalthings/angular-signature/blob/master/src/signature.js#L50 and https://github.com/legalthings/angular-signature/blob/master/src/signature.js#L92) with no params which causes error in angular < 1.4.
bower.json
Either the dependency of angular or the usage of the function must be modified. I'll suggest to change the usage as it'll broaden the usability of package.
The minimum angular version mentioned in
bower.json
is 1.3 while there are two usages of $timeout() (at https://github.com/legalthings/angular-signature/blob/master/src/signature.js#L50 and https://github.com/legalthings/angular-signature/blob/master/src/signature.js#L92) with no params which causes error in angular < 1.4.Either the dependency of angular or the usage of the function must be modified. I'll suggest to change the usage as it'll broaden the usability of package.