legalthings / angular-signature

HTML5 canvas based smooth signature drawing as angularJS directive (http://szimek.github.io/signature_pad/)
MIT License
105 stars 91 forks source link

Incorrect Angular Dependency #67

Open saurabh-jtg opened 7 years ago

saurabh-jtg commented 7 years ago

The minimum angular version mentioned in bower.json is 1.3 while there are two usages of $timeout() (at https://github.com/legalthings/angular-signature/blob/master/src/signature.js#L50 and https://github.com/legalthings/angular-signature/blob/master/src/signature.js#L92) with no params which causes error in angular < 1.4.

Either the dependency of angular or the usage of the function must be modified. I'll suggest to change the usage as it'll broaden the usability of package.