legalthings / angular-signature

HTML5 canvas based smooth signature drawing as angularJS directive (http://szimek.github.io/signature_pad/)
MIT License
105 stars 91 forks source link

Remove code which clears dataURL #68

Open cheerfulstoic opened 6 years ago

cheerfulstoic commented 6 years ago

In using angular-signature we found that clicking on the signature pad repeatedly would cause it to clear out. I tested the signature_pad demo and I couldn't reproduce it, but I could reproduce it reliably in the angular-signature demo. Doing some debugging it seemed to come from the timeout in updateModel. When I removed the isEmpty check (as in this PR) we found that the problem went away and we didn't see any adverse effects.

So we were wondering: what was that code intended to do, and is it still needed?