search

legatoproject / legato-af

Legato Application Framework
Mozilla Public License 2.0
153 stars 118 forks source link

Issue with wrong name of the include guard in components/fwupdate/fwupdateDaemon/fwupdate_local.h #73

Open jumd opened 1 year ago

jumd commented 1 year ago

I recognized an issue with the include guard here.

https://github.com/legatoproject/legato-af/blob/44c2bda95f4e13344bf0cbaf730880694846e646/components/fwupdate/fwupdateDaemon/fwupdate_local.h#L9-L10

I guess it should be named LEGATO_FWUPDATE_LOCAL_INCLUDE_GUARD as also the last line of this file says as comment.

Otherwise it may not be possible to include both components/fwupdate/fwupdateDaemon/fwupdate_local.h and components/modemServices/modemDaemon/le_ecall_local.h in same application.

Regards Julian