legege / searchwp

Firefox Add-on: Find what you seek faster, using jump-to-word buttons and rich highlighting.
12 stars 1 forks source link

alt-click in search field. #59

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
It's an enhancement proposition :

The problem is that I have to click twice in the search field now to modify a 
word.
It'd be nice to have a alt-click to be able to position the insertion cursor in 
the middle of a word.

Also, the word in the search field should not move when it switches to the 
"button version".

Thanks.

Original issue reported on code.google.com by jie...@gmail.com on 12 Aug 2011 at 9:24

GoogleCodeExporter commented 9 years ago

Original comment by Robert.Katic on 23 Aug 2011 at 9:26

GoogleCodeExporter commented 9 years ago
Regarding the alt-click to position the caret in the middle of a word: How it 
would prevent you to click only once, since "the middle of a word" is probably 
not the place where you are going to insert changes.

> Also, the word in the search field should not move when it switches to the 
"button version".

How?

Original comment by Robert.Katic on 3 Sep 2011 at 12:56

GoogleCodeExporter commented 9 years ago
Ahh, replace in previous comment "prevent" with "ensure".

Original comment by Robert.Katic on 3 Sep 2011 at 12:59

GoogleCodeExporter commented 9 years ago
After some thinking, we actually can make alt-click on token buttons to 
position the caret exactly in the right place. This means that having token 
"word" and clicking on the button between "r" and "d", it would position the 
caret exactly after "r".
This would require some refactoring of the tokenizer, but it's not a problem.

Also we could add an option to switch behaviors of "click" and "alt-click".
Combining it with issue 67, one can use click to always edit (position caret), 
and mouse wheel up/down to search next/previous.

Original comment by Robert.Katic on 3 Sep 2011 at 2:09

GoogleCodeExporter commented 9 years ago
Seams that alt-click is already used to match-case search.
Therefore, I am closing this issue.

To handle caret positioning, I opened issue 68.

Original comment by Robert.Katic on 3 Sep 2011 at 2:44

GoogleCodeExporter commented 9 years ago
Hi,

thanks for considering my proposition about caret positioning.
If I put the idea of "words not moving when it switched" in the same issue, 
it's because when you click in text, one expect the caret to be right where he 
clicked.
In your comment 2, you asked "How ?". If it's possible in Firefox, using a 
white space bigger in between words in the non-buttoned version, or a smaller 
in the buttoned version should do the trick.

I don't know if it should stay in the same issue or not.

Original comment by jie...@gmail.com on 3 Sep 2011 at 1:25

GoogleCodeExporter commented 9 years ago
I am pretty sure that altering width of spaces would make most of users mad. I 
am not sure we want to make search-box to behave like a text editor with 
"justify text" turned on, where spaces have not fixed width, also because 
search-box is not as width as an A4 document.
Now, I can understand that word movement can be more annoying in cases of wider 
search-box with long queries, so feel free to open a new issue - I prefer to 
keep this one closed (problem separation).

Original comment by Robert.Katic on 3 Sep 2011 at 9:39