search

legend-exp / LegendDSP.jl

LEGEND digital signal processing in Julia
Other
1 stars 3 forks source link

Add new filters #39

Closed apmypb closed 1 month ago

apmypb commented 2 months ago

Added filters that could replace Savitzky-Golay and a moving average window filter. I wrote some working examples in the doc strings of the filters. I can add tests if needed

fhagemann commented 2 months ago

Can you please also include code examples in this PR?

apmypb commented 2 months ago

What exactly do you mean by examples? Each filters has code examples in their docs Or do you want unit tests?

oschulz commented 2 months ago

A test for each new filter would be great!

oschulz commented 1 month ago

@apmypb could you make separate source/test files for the separate filters (without code duplication)?

fhagemann commented 1 month ago

Fine to me. My two comments are:

  • Let's move the filters into one file to make the package structure cleaner.

@oschulz you are asking for exactly the opposite as @theHenks ….

oschulz commented 1 month ago

Let's move the filters into one file to make the package structure cleaner.

Fine, then let's leave it like this for now, we can deal with the package structure later.