search

legend-exp / LegendDataManagement.jl

LegendMetadata access in Julia
Other
1 stars 5 forks source link

Change Usability Key #15

Closed theHenks closed 9 months ago

theHenks commented 9 months ago

The usability key in the metadata has different meaning and treating it static as "on" = true is not enough since some channels have no_psd and ac and have to be processed anyhow. Changed this field to be a Symbol so that different selections can be performed.

image
oschulz commented 9 months ago

Can you have a look at the test? They should pass except on Windows (tests are currently broken on Win, we need to fix that separately).

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Files Coverage Δ
src/legend_data.jl 59.25% <ø> (ø)

:loudspeaker: Thoughts on this report? Let us know!

theHenks commented 9 months ago

I edited the tests. Should work now. You can now not check the usability anymore with $usability and you get a bool return. You have to explicitly state a usability state such as :on or :no_psd etc. I think it is ready to merge.