legend-exp / LegendDataManagement.jl

LegendMetadata access in Julia
Other
1 stars 5 forks source link

Processing updates #22

Closed theHenks closed 6 months ago

theHenks commented 7 months ago

Added functionality which was so far in the dataflow:

Also, I extended the channelinfo to be able to get the info for a given run and period by using the start_key as a reference and also to get a handy access to the :geds subsytem with

channelinfo(l200, (:p03, :r000, :cal))
channelinfo(l200, (:p03, :r000, :cal); system=:geds, processable=true)

This makes this whole process of getting filekeys etc way more handy and the user can just get the channelinfo for a given run much more human readable.

I will also move some of the addprocs functionality and try to start with some of the logging stuff. Maybe @oschulz, you could also share some ideas here. The missing features are here a way to first create Markdown logs and then write them. Then, a function savelegendfig would be nice which automatically generates figure names and saves a given figure. And the option to save units in the PropDicts as discussed.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (a898a51) 50.65% compared to head (59e5b50) 48.96%.

Files Patch % Lines
src/dataprod_config.jl 0.00% 26 Missing :warning:
src/legend_data.jl 45.45% 12 Missing :warning:
src/filekey.jl 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #22 +/- ## ========================================== - Coverage 50.65% 48.96% -1.69% ========================================== Files 15 15 Lines 922 966 +44 ========================================== + Hits 467 473 +6 - Misses 455 493 +38 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

theHenks commented 6 months ago

Ready to merge now from my side. What do you say @oschulz ?

oschulz commented 6 months ago

Thanks!