Closed theHenks closed 6 months ago
Attention: 44 lines
in your changes are missing coverage. Please review.
Comparison is base (
a898a51
) 50.65% compared to head (59e5b50
) 48.96%.
Files | Patch % | Lines |
---|---|---|
src/dataprod_config.jl | 0.00% | 26 Missing :warning: |
src/legend_data.jl | 45.45% | 12 Missing :warning: |
src/filekey.jl | 0.00% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ready to merge now from my side. What do you say @oschulz ?
Thanks!
Added functionality which was so far in the dataflow:
is_analysis_run
checks if the run is a analysis runstart_key
returns the starting FileKey for a given period and runphy_livetime
returns the livetime for a given run and periodAlso, I extended the
channelinfo
to be able to get the info for a given run and period by using thestart_key
as a reference and also to get a handy access to the:geds
subsytem withThis makes this whole process of getting filekeys etc way more handy and the user can just get the
channelinfo
for a given run much more human readable.I will also move some of the
addprocs
functionality and try to start with some of the logging stuff. Maybe @oschulz, you could also share some ideas here. The missing features are here a way to first create Markdown logs and then write them. Then, a functionsavelegendfig
would be nice which automatically generates figure names and saves a given figure. And the option to save units in thePropDicts
as discussed.