Closed theHenks closed 6 months ago
@oschulz I didn't touch the data_partitions
function yet since it has IDicts
as keys so far. In my opinion and for consistency, the keys should be DataPartitions
.
Attention: 21 lines
in your changes are missing coverage. Please review.
Comparison is base (
59e5b50
) 48.96% compared to head (bf6b821
) 48.11%. Report is 3 commits behind head on main.:exclamation: Current head bf6b821 differs from pull request most recent head d11d507. Consider uploading reports for the commit d11d507 to get more accurate results
Files | Patch % | Lines |
---|---|---|
src/filekey.jl | 0.00% | 17 Missing :warning: |
src/dataprod_config.jl | 0.00% | 2 Missing :warning: |
src/legend_data.jl | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@oschulz PR is ready to merge from my side.
channelinfo
together withRunCategorySelLike
forchannelinfo
with a singleDetectorId
as inpuDataPartition
struct to be used for parititons and therefore the naming within all future partitioning functionsDataSelector
compatible withPropDicts
. Otherwise, this doesn't work: