Closed fhagemann closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
59e5b50
) 48.96% compared to head (4582365
) 48.96%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Nice, no more failing tests on Windows
Thanks a lot!
The tests on Windows keep on failing since implementing the support for colon-separated filenames in
LEGEND_DATA_CONFIG
in commit https://github.com/legend-exp/LegendDataManagement.jl/commit/80b0c1182433693b4a298ee8670f8f9d933ba99a.What happens is that
LEGEND_DATA_CONFIG
is split at every colon, including the colons that might belong to a Windows file path (C:\\...
). In this PR, I replaced the simple':'
as the split condition with a regular expressionr":(?!\\)
to avoid splitting:\\
as expected in Windows file paths.I hope that the tests on Windows will pass again with this fix.