search

legend-exp / LegendDataManagement.jl

LegendMetadata access in Julia
Other
1 stars 5 forks source link

Bugfix in parsing `LegendDataConfig` on Windows #25

Closed fhagemann closed 6 months ago

fhagemann commented 6 months ago

The tests on Windows keep on failing since implementing the support for colon-separated filenames in LEGEND_DATA_CONFIG in commit https://github.com/legend-exp/LegendDataManagement.jl/commit/80b0c1182433693b4a298ee8670f8f9d933ba99a.

What happens is that LEGEND_DATA_CONFIG is split at every colon, including the colons that might belong to a Windows file path (C:\\...). In this PR, I replaced the simple ':' as the split condition with a regular expression r":(?!\\) to avoid splitting :\\ as expected in Windows file paths.

I hope that the tests on Windows will pass again with this fix.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (59e5b50) 48.96% compared to head (4582365) 48.96%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #25 +/- ## ======================================= Coverage 48.96% 48.96% ======================================= Files 15 15 Lines 966 966 ======================================= Hits 473 473 Misses 493 493 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fhagemann commented 6 months ago

Nice, no more failing tests on Windows

oschulz commented 6 months ago

Thanks a lot!