Closed fhagemann closed 1 month ago
Attention: Patch coverage is 50.00000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 35.85%. Comparing base (
5c85deb
) to head (bee60bb
). Report is 15 commits behind head on dev.
Files | Patch % | Lines |
---|---|---|
src/filekey.jl | 50.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR addresses the changes in commit 57c3eb1b96c5034d020013bedb60b93bdff0db29.
Seems like there are two kinds of
ChannelIds
: one with three digits (old) and one with seven digits (new). The implementation of how to check the validity of aChannelId
seemed a bit buggy. I tried to fix it but would need some feedback from people who have worked withChannelIds
more.My understanding:
ChannelId
can be anything from 0 (or 1?) to 999.ChannelId
cannot have the first two digits being BOTH 0, otherwise they can be whatever.If this is true, I updated the regular expression
ch_expr
. I also updated the code to add leading zeros toIntegers
before being checked for validity.This might prevent the current tests from failing.