Remove type piracy plotting recipes

legend-exp / LegendDataManagement.jl

LegendMetadata access in Julia

Other

1 stars 4 forks source link

Remove type piracy plotting recipes #51

Open oschulz opened 2 weeks ago

oschulz commented 2 weeks ago

This is type piracy and has to go:

https://github.com/legend-exp/LegendDataManagement.jl/blob/0a74d75c9081ba6844db51016d4704576e1934a2/ext/LegendDataManagementRecipesBaseExt.jl#L13

LegendDataManagement must not define plotting recipes for types it does not own!

fhagemann commented 2 weeks ago

Do I need to define a new struct or type in LegendDataManagement or is it enough to "just" specify the column names of the Table using an alias?

oschulz commented 2 weeks ago

It should really be a type owned by LegendDataManagement.