fhagemann
commented
2 years ago All 112 detectors from the meta file directory can be read in without error. However, some of them throw warnings if they are of special case (bulletization, crack, etc.)
Closed fhagemann closed 2 years ago
fhagemann
commented
2 years ago All 112 detectors from the meta file directory can be read in without error. However, some of them throw warnings if they are of special case (bulletization, crack, etc.)
codecov-commenter
commented
2 years ago Merging #18 (dcaa8b2) into main (7e12348) will increase coverage by
1.65%. The diff coverage is65.51%.
@@ Coverage Diff @@
## main #18 +/- ##
==========================================
+ Coverage 25.82% 27.47% +1.65%
==========================================
Files 18 18
Lines 639 666 +27
==========================================
+ Hits 165 183 +18
- Misses 474 483 +9 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/legend_detector_to_ssd.jl | 67.68% <65.51%> (-0.21%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Right now, we should be able to correctly read in the metadata to construct the semiconductor and the contacts. However, some very special cases (top groove, crack, bulletization and multi-radius detectors) are not supported yet but a warning shows up that these fields will be ignored if the values are non-zero.