legend-exp / LegendGeSim.jl

High-level Julia package for LEGEND HPGe detector simulation
Other
2 stars 8 forks source link

Update IO to new LEGEND metadata format #27

Closed fhagemann closed 1 year ago

fhagemann commented 1 year ago

There were some more format changes to the metadata files which cause the current version of LegendGeSim.jl to throw errors when reading files in the new format.

I updated the IO of LEGEND metadata files by incorporating the following changes:

I again assume the tests to fail because we might also need to update the legend-testdata.

oschulz commented 1 year ago

Can we use the new diode metadata in legend-testdata (https://github.com/legend-exp/legend-testdata/tree/main/data/legend/metadata/hardware/detectors/germanium/diodes) ?

fhagemann commented 1 year ago

Yes that should be fine

oschulz commented 1 year ago

Yes that should be fine

Can you try, if you find a free moment?

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 69.90% and project coverage change: +1.64 :tada:

Comparison is base (8a460ea) 26.43% compared to head (b76b0c0) 28.07%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #27 +/- ## ========================================== + Coverage 26.43% 28.07% +1.64% ========================================== Files 18 19 +1 Lines 681 691 +10 ========================================== + Hits 180 194 +14 + Misses 501 497 -4 ``` | [Impacted Files](https://app.codecov.io/gh/legend-exp/LegendGeSim.jl/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp) | Coverage Δ | | |---|---|---| | [src/legend\_detector\_to\_ssd.jl](https://app.codecov.io/gh/legend-exp/LegendGeSim.jl/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp#diff-c3JjL2xlZ2VuZF9kZXRlY3Rvcl90b19zc2Quamw=) | `71.25% <69.90%> (+4.16%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/legend-exp/LegendGeSim.jl/pull/27/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.