Closed fhagemann closed 1 year ago
Can we use the new diode metadata in legend-testdata (https://github.com/legend-exp/legend-testdata/tree/main/data/legend/metadata/hardware/detectors/germanium/diodes) ?
Yes that should be fine
Yes that should be fine
Can you try, if you find a free moment?
Patch coverage: 69.90
% and project coverage change: +1.64
:tada:
Comparison is base (
8a460ea
) 26.43% compared to head (b76b0c0
) 28.07%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
There were some more format changes to the metadata files which cause the current version of LegendGeSim.jl to throw errors when reading files in the new format.
I updated the IO of LEGEND metadata files by incorporating the following changes:
height
instead ofgap
top.outer
taper was renamed totop
tapertop.inner
taper was renamed toborehole
taperbottom.outer
taper was renamed tobottom
tapercontact
was renamed topp_contact
icpc
detectors andcoax
detectors are parsed differently due to differences in geometrycoax
are parsed differently due to differences in geometryI again assume the tests to fail because we might also need to update the legend-testdata.