Closed github-actions[bot] closed 1 year ago
Patch and project coverage have no change.
Comparison is base (
7af871d
) 14.80% compared to head (83c2021
) 14.80%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@fhagemann are there breaking changes in SSD v0.9 that would affect LegendGeSim?
There are changes how keyword arguments are passed to estimate_depletion_voltage
.
I am not sure where/if that affects LegendGeSim, but I think we should first make sure to converge the fork of @sagitta42 onto the legend-exp/main before thinking about compatibility with SolidStateDetectors.jl
Okay, it looks like neither the current main
nor the megadev
are using estimate_depletion_voltage
, so we should be able to merge this without problems.
The code itself does not use this function, only my notebook does, and it's not uploaded yet
Then, I would propose to merge this right away.
This pull request changes the compat entry for the
SolidStateDetectors
package from0.8
to0.8, 0.9
. This keeps the compat entries for earlier versions.Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.