legend-exp / LegendGeSim.jl

High-level Julia package for LEGEND HPGe detector simulation
Other
2 stars 8 forks source link

CompatHelper: bump compat for SolidStateDetectors to 0.9, (keep existing compat) #32

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

This pull request changes the compat entry for the SolidStateDetectors package from 0.8 to 0.8, 0.9. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (7af871d) 14.80% compared to head (83c2021) 14.80%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #32 +/- ## ======================================= Coverage 14.80% 14.80% ======================================= Files 19 19 Lines 527 527 ======================================= Hits 78 78 Misses 449 449 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

oschulz commented 1 year ago

@fhagemann are there breaking changes in SSD v0.9 that would affect LegendGeSim?

fhagemann commented 1 year ago

There are changes how keyword arguments are passed to estimate_depletion_voltage. I am not sure where/if that affects LegendGeSim, but I think we should first make sure to converge the fork of @sagitta42 onto the legend-exp/main before thinking about compatibility with SolidStateDetectors.jl

fhagemann commented 1 year ago

Okay, it looks like neither the current main nor the megadev are using estimate_depletion_voltage, so we should be able to merge this without problems.

sagitta42 commented 1 year ago

The code itself does not use this function, only my notebook does, and it's not uploaded yet

fhagemann commented 1 year ago

Then, I would propose to merge this right away.