search

legend-exp / LegendHDF5IO.jl

HDF5-IO in Julia for the LEGEND experiment
Other
0 stars 6 forks source link

`Base.size` has type instabilities #24

Closed fhagemann closed 1 year ago

fhagemann commented 1 year ago

https://github.com/legend-exp/LegendHDF5IO.jl/blob/1ced4f281e525116862595436774dfb7a879b535/src/types.jl#L192

When calling size(lha::LH5Array) it does not know the dimensions of LH5Array even though it should. Can the size function be adapted such that it works like that for arrays? There, we see no type instabilities.

@apmypb

oschulz commented 1 year ago

Yes, size should definitely work.

fhagemann commented 1 year ago

Solved with #26