legend-exp / LegendHDF5IO.jl

HDF5-IO in Julia for the LEGEND experiment
Other
0 stars 6 forks source link

Fix unused declared type variables in method definitions #25

Closed fhagemann closed 1 year ago

fhagemann commented 1 year ago

When precompiling, this packages throws warning that some type variables in method definition are declared but not used. I have looked through the list of warnings and removed unused type variables.

codecov-commenter commented 1 year ago

Codecov Report

Base: 49.28% // Head: 49.28% // No change to project coverage :thumbsup:

Coverage data is based on head (a9a9f44) compared to base (1ced4f2). Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #25 +/- ## ======================================= Coverage 49.28% 49.28% ======================================= Files 6 6 Lines 562 562 ======================================= Hits 277 277 Misses 285 285 ``` | [Impacted Files](https://codecov.io/gh/legend-exp/LegendHDF5IO.jl/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp) | Coverage Δ | | |---|---|---| | [src/histogram\_io.jl](https://codecov.io/gh/legend-exp/LegendHDF5IO.jl/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp#diff-c3JjL2hpc3RvZ3JhbV9pby5qbA==) | `72.00% <ø> (ø)` | | | [src/radsig\_io.jl](https://codecov.io/gh/legend-exp/LegendHDF5IO.jl/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp#diff-c3JjL3JhZHNpZ19pby5qbA==) | `53.33% <ø> (ø)` | | | [src/generic\_io.jl](https://codecov.io/gh/legend-exp/LegendHDF5IO.jl/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp#diff-c3JjL2dlbmVyaWNfaW8uamw=) | `32.26% <66.66%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.