legend-exp / legend-dataflow

LEGEND data flow management
Other
2 stars 9 forks source link

Modularize workflow #23

Closed gipert closed 7 months ago

gipert commented 8 months ago

The main Snakefile would be more readable if we factor out parts:

Snakefile
rules/build_dsp.smk
rules/build_hit.smk
...

and then include them back with the Snakemake include directive.

ggmarshall commented 8 months ago

This is tricky as snakemake is not installed and all rules need access to the scripts dir so need a nice way to specify relative paths to modules

gipert commented 8 months ago

Uhm not sure what you mean, it works as expected in the simflow:

https://github.com/legend-exp/legend-simflow/blob/main/Snakefile#L307

ggmarshall commented 8 months ago

ah my misunderstanding it seems when it is imported by snakemake the imports are done after

gipert commented 8 months ago

Yes, it's really nothing more than a dumb paste of the code from the module into the Snakefile