search

legend-exp / legend-pydataobj

LEGEND Python Data Objects
https://legend-pydataobj.readthedocs.io
GNU General Public License v3.0
1 stars 9 forks source link

Bug fix in `LH5Store.read()`: check for `n_rows` longer than `idx`s before dropping #65

Closed ggmarshall closed 7 months ago

ggmarshall commented 7 months ago

Last pr could introduce unintended behaviour if user specifies n_rows longer than the idxs provided

codecov[bot] commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ae371f2) 72.91% compared to head (e5ed8ff) 72.89%. Report is 1 commits behind head on main.

Files Patch % Lines
src/lgdo/lh5/store.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #65 +/- ## ========================================== - Coverage 72.91% 72.89% -0.02% ========================================== Files 29 29 Lines 2466 2468 +2 ========================================== + Hits 1798 1799 +1 - Misses 668 669 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.