legend-exp / legend-pygeom-hpges

Germanium detector geometries for radiation transport simulations
https://legend-pygeom-hpges.readthedocs.io
GNU General Public License v3.0
0 stars 4 forks source link

Bug fix: duplicated r,z-pairs in some ICPC detectors #17

Closed nikolay327 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.80 :warning:

Comparison is base (1bbcd73) 81.05% compared to head (81c51f9) 80.25%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #17 +/- ## ========================================== - Coverage 81.05% 80.25% -0.80% ========================================== Files 14 14 Lines 533 542 +9 ========================================== + Hits 432 435 +3 - Misses 101 107 +6 ``` | [Impacted Files](https://app.codecov.io/gh/legend-exp/legend-pygeom-hpges/pull/17?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp) | Coverage Δ | | |---|---|---| | [src/legendhpges/invcoax.py](https://app.codecov.io/gh/legend-exp/legend-pygeom-hpges/pull/17?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp#diff-c3JjL2xlZ2VuZGhwZ2VzL2ludmNvYXgucHk=) | `73.68% <60.00%> (-3.46%)` | :arrow_down: | | [src/legendhpges/v02160a.py](https://app.codecov.io/gh/legend-exp/legend-pygeom-hpges/pull/17?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp#diff-c3JjL2xlZ2VuZGhwZ2VzL3YwMjE2MGEucHk=) | `87.01% <60.00%> (-2.18%)` | :arrow_down: | | [src/legendhpges/v07646a.py](https://app.codecov.io/gh/legend-exp/legend-pygeom-hpges/pull/17?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp#diff-c3JjL2xlZ2VuZGhwZ2VzL3YwNzY0NmEucHk=) | `75.60% <60.00%> (-3.34%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

gipert commented 1 year ago

Thanks Niko!