legend-exp / legend-pygeom-hpges

Germanium detector geometries for radiation transport simulations
https://legend-pygeom-hpges.readthedocs.io
GNU General Public License v3.0
0 stars 4 forks source link

Adding V07646A detector with a special geometry #9

Closed nikolay327 closed 1 year ago

nikolay327 commented 1 year ago

V07646A

gipert commented 1 year ago

Thanks Niko! Could you please replace the values in the JSON test file with dummy (but reasonable) values? That is "private" information.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 79.54% and project coverage change: +0.92 :tada:

Comparison is base (8995f8f) 71.92% compared to head (03b2485) 72.84%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9 +/- ## ========================================== + Coverage 71.92% 72.84% +0.92% ========================================== Files 10 11 +1 Lines 260 302 +42 ========================================== + Hits 187 220 +33 - Misses 73 82 +9 ``` | [Impacted Files](https://app.codecov.io/gh/legend-exp/legend-pygeom-hpges/pull/9?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp) | Coverage Δ | | |---|---|---| | [src/legendhpges/make\_hpge.py](https://app.codecov.io/gh/legend-exp/legend-pygeom-hpges/pull/9?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp#diff-c3JjL2xlZ2VuZGhwZ2VzL21ha2VfaHBnZS5weQ==) | `93.10% <75.00%> (-3.06%)` | :arrow_down: | | [src/legendhpges/v07646a.py](https://app.codecov.io/gh/legend-exp/legend-pygeom-hpges/pull/9?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp#diff-c3JjL2xlZ2VuZGhwZ2VzL3YwNzY0NmEucHk=) | `78.94% <78.94%> (ø)` | | | [src/legendhpges/\_\_init\_\_.py](https://app.codecov.io/gh/legend-exp/legend-pygeom-hpges/pull/9?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=legend-exp#diff-c3JjL2xlZ2VuZGhwZ2VzL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

nikolay327 commented 1 year ago

Thanks Niko! Could you please replace the values in the JSON test file with dummy (but reasonable) values? That is "private" information.

Done!

gipert commented 1 year ago

Can you also update make_hpge() to handle this please?