Closed ggmarshall closed 1 year ago
Patch coverage: 1.53%
and project coverage change: -1.49%
:warning:
Comparison is base (
034a3fb
) 21.09% compared to head (c15507b
) 19.60%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
looks good to me
Looks good to me. codecov is complaining that this puts us under the test coverage percentage but that's not just this PRs fault. Will merge anyway.
Energy calibration - switch to minos, improvements to output plots, add fit errors into outputs, bugfix on final ecal fit, changed default to use all events, now returns the fit of the peak even if failed with tag as to whether it failed or not. A/E - added time correction code, refactored pdfs to make easier to add new fit functions, added ability to apply drift time cuts for batch 5s, dep correction, general improvements to fitting.