Bugfix for issue 516 - Githubissues

legend-exp / pygama

Python package for data processing and analysis

https://pygama.readthedocs.io

GNU General Public License v3.0

18 stars 56 forks source link

Closed MoritzNeuberger closed 1 year ago

MoritzNeuberger commented 1 year ago

Fixed the bug that drop_idx in build_entry_list was not filled if no cuts were set by removing the continue condition and making the default value of cut cut = "" which is changed if self.cuts is not None and level in self.cuts.keys().
Added continue condition if self.table_list is not None but not level in self.table_list.keys(). Otherwise the loop over tables would throw an error.

codecov[bot] commented 1 year ago

Attention: 1 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
src/pygama/flow/data_loader.py	`77.07% <85.71%> (-0.02%)`	:arrow_down:

:loudspeaker: Thoughts on this report? Let us know!.

gipert commented 1 year ago

This looks straightforward to me, I will merge it.