search

legesher / legesher-translations

Home of all the translations for spoken languages into programming language
MIT License
53 stars 109 forks source link

Review Language: Telugu (Python) #172

Closed madiedgar closed 11 months ago

madiedgar commented 3 years ago

Review Telugu Translations for Python

In order to review this language to the project, complete the steps detailed in the translation guide (from Step #6 onward). We are primarily working developing Legesher for the Python programming language. In the future we hope to add more programming languages in the future.

Reviewing a translation is extremely important as we want to best understand the culture and context behind the words we select as keywords for the programming languages. The more perspectives the better! 👀Please take your time in being thorough with these translations. Think back when you were learning how to program and how context of words help you bridge together meaning and functionality.

⚠️ Note: this issue is to review the Python keywords and builtin functions only. Any additional translation reviews are encouraged, but not necessary.

To complete this issue:

Reviewers Needed

In order to add the translations for official use across Legesher, the translations will need to be approved and accepted by 5 additional native / fluent speakers. If you would like to be one of the reviewers for this language, please mention in this issue! :smile: Also feel free to loop in a friend that might be able to help with the translations! Please refer to the translation guide for the next step in the review process.

Review Status:

manojkrishnak commented 2 years ago

Hi, i would like to take this up.

I do have few doubts can I ping you on any platform? Discord?

madiedgar commented 2 years ago

Absolutely! I'll assign you for now and feel free to message me on discord. I'd love to hear your thoughts 👍

manojkrishnak commented 2 years ago

Hi @madiedgar, I tried contacting you on Discord, seems like you have disabled DMs without being friend there, could you pls allow me to send messages?

Ln11211 commented 2 years ago

@madiedgar, Like I promised, I want to review "Telugu", Can I start with reviewing ?

madiedgar commented 2 years ago

Absolutely @Ln11211 , I'll assign you to this issue as well!

Ln11211 commented 2 years ago

@madiedgar, I have seen that only Keywords of the Python were translated into Telugu and not the functions, so I only reviewed them. I have also decided to translate the functions once I submit a PR(for keywords review).

Ln11211 commented 2 years ago

@madiedgar, so I noticed that you have refactored the translation files, and I keep getting these notifications to raise a PR for the previous commits, and I am totally confused I mean I already did raise a pr back a while ago, right ? , is this normal ?, can you help me ?

image

madiedgar commented 2 years ago

Hmm @Ln11211 , let me look into that and get back to you. I'm getting several questions about how to keep branches up to date. Would having a tutorial on how to keep the your translation branch updated with Legesher's translation branch be helpful? Can you think of some areas that might be hurdles for new contributors / things worth mentioning?

Ln11211 commented 2 years ago

@madiedgar , sure, I'll make a list of all important "to-do's" for new contributors and I'll get back to you...

Ln11211 commented 2 years ago

@madiedgar, so I noticed that you have refactored the translation files, and I keep getting these notifications to raise a PR for the previous commits, and I am totally confused I mean I already did raise a pr back a while ago, right ? , is this normal ?, can you help me ?

image

@madiedgar , I guess I understood why the git is asking me to raise a pr every time I merge a new commit(the one's that I am behind) to my forked repo, well if any new commits were merged (into the master at your end) while I raise a pr or if there were new commits that were merged at your end and I have a pr that's in review or about to be merged and If I fail to pull and merge them into my branch, we will encounter the same issue that I am facing right now. So I missed including (and merging) certain commits (like the refactored code commit, and the other commit just after that) into my branch while my pr was in the review state.., It's an error from my side that messed my timeline(making my branches outdated)..

KarthikMothiki commented 2 years ago

Hello @madiedgar, I would like to contribute to this project.

madiedgar commented 2 years ago

@madiedgar, so I noticed that you have refactored the translation files, and I keep getting these notifications to raise a PR for the previous commits, and I am totally confused I mean I already did raise a pr back a while ago, right ? , is this normal ?, can you help me ? image

@madiedgar , I guess I understood why the git is asking me to raise a pr every time I merge a new commit(the one's that I am behind) to my forked repo, well if any new commits were merged (into the master at your end) while I raise a pr or if there were new commits that were merged at your end and I have a pr that's in review or about to be merged and If I fail to pull and merge them into my branch, we will encounter the same issue that I am facing right now. So I missed including (and merging) certain commits (like the refactored code commit, and the other commit just after that) into my branch while my pr was in the review state.., It's an error from my side that messed my timeline(making my branches outdated)..

This is actually really helpful to know @Ln11211, because you're not the only one encountering this. Would you be willing to write a short tutorial on how to resolve this that we can refer people to?

Ln11211 commented 2 years ago

@madiedgar sure !

KarthikMothiki commented 2 years ago

Hello @madiedgar, I created a PR. I have a doubt, I don't know why the Unibeautify bot showing all checks have failed. I'm actually new to Open Source Contribution, could you please help me with this?

error

Ln11211 commented 2 years ago

@KarthikMothiki , I'm sure your pr is fine, don't worry about this, but @madiedgar why does this happen though?

KarthikMothiki commented 2 years ago

@madiedgar could you please give any update on this? Sorry for mentioning multiple times 😅😅

madiedgar commented 2 years ago

Thanks for your patience @KarthikMothiki! I will look at your PR shortly. But don't worry about the unibeautify error. The linter doesn't work properly when you're making a commit on a branch & merging it into another branch instead of master.

Ln11211 commented 2 years ago

This is actually really helpful to know @Ln11211, because you're not the only one encountering this. Would you be willing to write a short tutorial on how to resolve this that we can refer people to?

@madiedgar , I uploaded the document to our discord server 🙂

Ln11211 commented 2 years ago

@madiedgar Can I please translate JAVA keywords into Telugu and Hindi?

madiedgar commented 2 years ago

Hi @Ln11211 👋 , could you actually start the initial translation of the Python Builtin functions instead? That would be extremely helpful!

KarthikMothiki commented 2 years ago

@madiedgar I translated built-in functions and keywords into Telugu. Created a PR!

sujithkdola commented 1 year ago

hey @madiedgar, i would like to contribute to this project.

madiedgar commented 11 months ago

Happy October @Sujithkumardola, @Ln11211, @KarthikMothiki, @manojkrishnak, and @nagendrady, thank you for your early support on this project! I'm excited about adding the Telugu translation to Legesher, but I could use your assistance in gathering enough reviewers. Would you consider reaching out to your friends or peers who share an interest and invite them to join us? 😄 Thank you!

KarthikMothiki commented 11 months ago

Sure @madiedgar, I'll recommend my peers to review the project.

On Mon, Oct 2, 2023 at 2:14 AM Madi (Pfaff) Edgar @.***> wrote:

Happy October @Sujithkumardola https://github.com/Sujithkumardola, @Ln11211 https://github.com/Ln11211, @KarthikMothiki https://github.com/KarthikMothiki, @manojkrishnak https://github.com/manojkrishnak, and @nagendrady https://github.com/nagendrady, thank you for your early support on this project! I'm excited about adding the Telugu translation to Legesher, but I could use your assistance in gathering enough reviewers. Would you consider reaching out to your friends or peers who share an interest and invite them to join us? 😄 Thank you!

— Reply to this email directly, view it on GitHub https://github.com/legesher/legesher-translations/issues/172#issuecomment-1742196549, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5IX6RQ6KKE7TWBKOQVEKTX5HI3VANCNFSM4TDKL3XQ . You are receiving this because you were mentioned.Message ID: @.***>

sh1fu-X commented 11 months ago

Hello @madiedgar,

I'm excited to contribute to the Telugu translation for Legesher! Count me in. Let me know where I can get started.

sneha-thyagarajan commented 11 months ago

Hello @madiedgar , I'm glad to hear that you are adding Telugu translation to Legesher. I'm definitely interested in reviewing them

sneha-thyagarajan commented 11 months ago

Hello @madiedgar, I've completed my review of the Telugu translations. The translations are nearly perfect, and I've included alternative word choices in the comments where I thought they were needed. Created a PR!

madiedgar commented 11 months ago

@sneha-thyagarajan your PR looks great, I just left a review. @sh1fu-X start by creating a branch from the telugu-translation branch. Add your review based off the information from this translation guide. When you complete the python keywords and built-in functions raise a PR. 😄

sh1fu-X commented 11 months ago

Hello @madiedgar, I've finished reviewing the Telugu translations and have offered suggestions where they appeared necessary.

madiedgar commented 11 months ago

We've reached our requirement for reviewers on the Python keywords and built-in functions! 🎉 Be on the lookout for an Official Review PR for Telugu 👀

sneha-thyagarajan commented 11 months ago

Hey @madiedgar, I'm glad I could help with this issue. I'm happy to work on Telugu translations/ reviews for other programming languages as well. Count me in if you need help with this in the future.