search

leggedrobotics / darknet_ros

YOLO ROS: Real-Time Object Detection for ROS
BSD 3-Clause "New" or "Revised" License
2.14k stars 1.17k forks source link

ROS deb packages not building #55

Open mikaelarguedas opened 6 years ago

mikaelarguedas commented 6 years ago

Hi @mbjelonic,

Cool package :+1:

I saw this was released on the ROS buildfarm but never succeeded to build due to the missing darknet submodule. This can be solved in various ways (from the nicest to the riskiest):

  1. release darknet as a standalone ros package, that allows to get rid of the submodule issue and also to remove the darknet package completely the day it gets packaged as an official deb
  2. Use CMake external project feature. This is known to work with bloom. An example can be found at: https://github.com/esteve/LMS1xx/blob/619ff1ff42124cc9628f9c8e244aad79b0c0763d/CMakeLists.txt#L10-L18 con: This means downloading and compiling 3rd party code at build time
  3. Clone and init the submodule in CMake. Still unclear to me if this works well with bloom or not: https://github.com/ros-infrastructure/bloom/issues/217 con: This means downloading and compiling 3rd party code at build time
mbjelonic commented 6 years ago

Hi @mikaelarguedas, thanks for the detailed information. I am aware of this problem and I will look into this. Best, Marko