search

leggedrobotics / ros_best_practices

Best practices, conventions, and tricks for ROS
https://rsl.ethz.ch/education-students/lectures/ros.html
BSD 3-Clause "New" or "Revised" License
1.51k stars 415 forks source link

Add Eigen and Boost dependencies #10

Closed remod closed 6 years ago

remod commented 6 years ago

Adding Eigen and Boost to CMakeLists.txt/package.xml would help with how to handle these deps correctly.

Do you agree?

pfankhauser commented 6 years ago

Yes, I agree, but maybe we should include them but commented out, such that the user can active them if needed.

remod commented 6 years ago

See https://github.com/ethz-asl/ros_best_practices/pull/11.