leggedrobotics / ros_best_practices

Best practices, conventions, and tricks for ROS
https://rsl.ethz.ch/education-students/lectures/ros.html
BSD 3-Clause "New" or "Revised" License
1.51k stars 415 forks source link

Naming Convention Violations for Variables in RosPackageTemplate #42

Open neriyashul opened 1 year ago

neriyashul commented 1 year ago

The member variables in the RosPackageTemplate package of this repository are not following the recommended naming conventions outlined in the ROS C++ Style Guide.

According to ROS style guide, member variables should be named using under_scored, while in the current implementation, camelCase is used.

For example, in the RosPackageTemplate class:

- serviceServer_
- subscriberTopic_
- nodeHandle_

I have no problem making a pull request to address this issue if needed.