search

leggedrobotics / ros_best_practices

Best practices, conventions, and tricks for ROS
https://rsl.ethz.ch/education-students/lectures/ros.html
BSD 3-Clause "New" or "Revised" License
1.49k stars 413 forks source link

Added namespace folder in src folder. #8

Closed remod closed 6 years ago

remod commented 6 years ago

In my opinion, having the same folder structure in src and include helps to find files with increasing size of the package.

pfankhauser commented 6 years ago

I see your point, but this is not something that is typically done (at least as far as I can judge from other ROS packages). However, I agree that one can structure the src and include folders for a better structure (e.g., https://github.com/ethz-asl/grid_map/tree/master/grid_map_core/include/grid_map_core), but this is different from your PR. Any thoughts?

remod commented 6 years ago

Ok, that is probably a matter of taste. :)

I guess everybody who creates a huge package will notice himself and introduce folders (in one way or the other). Let's discard this PR.