search

leginon-org / leginon-redmine-archive

1 stars 0 forks source link

Frealign refinejob form hp and lp are reversed #2302

Open leginonbot opened 6 months ago

leginonbot commented 6 months ago

Author Name: Anchi Cheng (@anchi2c) Original Redmine Issue: 2302, https://emg.nysbc.org/redmine/issues/2302 Original Date: 2013-03-21 Original Assignee: Dmitry Lyumkis

selectPreparedRecon.php gives wrong RMAX1 and RMAX2 to frealign refinement and wrong help string.

Low resolution limit imposes a high-pass filter (hp) High resolution limit imposes a low-pass filter (lp)

leginonbot commented 6 months ago

Original Redmine Comment Author Name: Anchi Cheng (@anchi2c) Original Date: 2013-03-21T20:59:00Z

r17480 switch the object.

testing:

  1. Show the frealign refinement selection form such as myamiweb/processing/selectPreparedRecon.php?expId=9668
  2. The RMAX1 should give help string for high-pass filter.
  3. When default parameters are set, RMAX1 should be 300 while RMAX2 should be smaller number
  4. When the command is displayed hp=300 and lp=10 should be the default.
leginonbot commented 6 months ago

Original Redmine Comment Author Name: Dmitry Lyumkis (@LyumkisLab) Original Date: 2013-03-22T22:17:09Z

looks good, except that the default for "low-pass filter (lp)" should not say "2*nyquist"

leginonbot commented 6 months ago

Original Redmine Comment Author Name: Anchi Cheng (@anchi2c) Original Date: 2013-03-23T11:27:53Z

nice review. Switched in r17483