leginon-org / leginon-redmine-archive

1 stars 0 forks source link

Corrector instruments in settings gui does not match what Leginon think it is on when initialized #2517

Closed leginonbot closed 7 months ago

leginonbot commented 7 months ago

Author Name: Anchi Cheng (@anchi2c) Original Redmine Issue: 2517, https://emg.nysbc.org/redmine/issues/2517 Original Date: 2013-09-12 Original Assignee: Anchi Cheng


Instrument in settings are typically shown as the one last loaded but GetValue of the widget gives what is last saved in the database. This is because Loading instrument often is delayed so that the widget was already set.

This causes a confusion since we will see the last loaded instrument selected but when we close the settings dialog and collect the reference image, they would be of the instrument in the database since the instrument are not set when the dialog is closed but are set when the selector choice is changed.

This problem was not obvious until we start having multiple camera on the same scope and different tem classes set for regular TEM vs EFTEM.

leginonbot commented 7 months ago

Original Redmine Comment Author Name: Anchi Cheng (@anchi2c) Original Date: 2013-09-13T04:30:59Z


r17888 sets the values of the instruments with the widget values. This forces all values become the database values unless the database instrument is not available to the Leginon session, in which case None is given. At least it is consistent so the users will know it.

This change are applied to 2.2 as r17889 and to 2.2-redux as r17890

leginonbot commented 7 months ago

Original Redmine Comment Author Name: Anchi Cheng (@anchi2c) Original Date: 2013-09-13T15:34:24Z


Scott tested it for issue #2516 and it worked.

leginonbot commented 7 months ago

Original Redmine Comment Author Name: Anchi Cheng (@anchi2c) Original Date: 2013-09-18T19:19:26Z


r17899,r17900,r17901 fixes the None assignment bug introduced by this.

leginonbot commented 7 months ago

Original Redmine Comment Author Name: Anchi Cheng (@anchi2c) Original Date: 2014-01-13T02:40:15Z


No one to review. Tested.