search

leginon-org / leginon-redmine-archive

1 stars 0 forks source link

signature in appion #368

Closed leginonbot closed 7 months ago

leginonbot commented 7 months ago

Author Name: Gabriel Lander (@gclander) Original Redmine Issue: 368, https://emg.nysbc.org/redmine/issues/368 Original Date: 2010-04-21 Original Assignee: Amber Herold

wrapper for the batch version of signature, which can be found here: http://emlab.rose2.brandeis.edu/signature no threading support right now

r13564

leginonbot commented 7 months ago

Original Redmine Comment Author Name: Amber Herold (Amber Herold) Original Date: 2010-05-11T14:56:16Z

Gabe, I only looked at this briefly, but this is scary to me: while proc.poll() is None: sys.stderr.write(".") time.sleep(waittime) logf.flush() proc.wait()

I suppose when threading is implemented that will go away?

Also on lines 47 and 153 of signaturePicker.py there seems to be a superfluous i in the for loops, or did I miss something?

I think that for the release, we will most likely hide the signature tool with the config file parameter HIDE_FEATURE since we have not had a chance to test it and don't have it installed here. To enable it, just set HIDE_FEATURE to true in config.php under myamiweb.

leginonbot commented 7 months ago

Original Redmine Comment Author Name: Gabriel Lander (@gclander) Original Date: 2010-05-11T17:19:20Z

Hi Amber,

sorry, I copied this code directly from "apFindEM.py", feel free to fix it however you see necessary.

leginonbot commented 7 months ago

Original Redmine Comment Author Name: Gabriel Lander (@gclander) Original Date: 2010-05-11T17:25:02Z

oh, and the "i" you see in signaturePicker.py is indeed superfluous, again copied from code somewhere else. You can take it out.