legion-labs / legion

Legion monorepo, contains the legion engine, the tools, source control, build system etc...
https://book.legionengine.com
Other
16 stars 2 forks source link

Editor GUI to dynamic request an Editor Server Endpoint for a user. #2019

Open tltran-legion opened 2 years ago

tltran-legion commented 2 years ago

Summary

The goal is to have a mechanism on the Editor GUI to request the Governance Service for the allocation dynamic of an Editor/Runtime endpoint and Connect the Editor GUI directly to the endpoint provided by the Governance Service.

It is also important to mention that Editor GUI needs to use the Authentication provided with the Governance Service to authenticate and manage session of the user.

Current State

The actual version of the Editor GUI needs that the user pass manually in the url the parameters editor-server-url and runtime-server-url. Those parameter represent the endpoint of Editor/Runtime server connection entry. This mechanism is not efficient, not user friendly and error prone. To improve the mechanism, the Governance service will provide an API that Editor GUI can call and request dynamically endpoint required for the Editor GUI.

Tasks

DoD

kevin-legion commented 2 years ago

Just a small update on query parameters: instead of editor-server-url and runtime-server-url, it's now grpc-editor-server-url, grpc-runtime-server-url, rest-editor-server-url, and rest-runtime-server-url (where the grpc version is similar to the previous one).

kevin-legion commented 2 years ago

I marked this issue as blocked as the governance service is not usable yet (as far as I know @ereOn). Also, I'm not sure that Governance will return the api urls, wouldn't be some sort of "Parameters" service instead ?

Update: We'll have a meeting soon to discuss about this, I'll let this issue "blocked" for now until then, feel free to "unblock" it things get clearer in the meantime 👍

kevin-legion commented 2 years ago

Some things we'll need to be done before this can be achieved (client):

Client tasks: