search

legionus / kbd

Mirror of https://git.kernel.org/pub/scm/linux/kernel/git/legion/kbd.git
https://kbd-project.org
Other
84 stars 41 forks source link

add timeout param #102

Closed stzdzyhs closed 1 year ago

stzdzyhs commented 1 year ago

Hello,
First thanks to create this useful tool ! I add a minor change, add a timeout param for showkey, hope it useful.

legionus commented 1 year ago

kbd uses DCO to format patches. Please add Signed-off-by tag in the commit message. Everything else looks good.

https://github.com/legionus/kbd/blob/master/docs/process/howto-contribute.md#sending-patches

stzdzyhs commented 1 year ago

Signed-off-by added

legionus commented 1 year ago

@stzdzyhs What's the point of the second commit?

legionus commented 1 year ago

please squash them and use git commit -s.

stzdzyhs commented 1 year ago

sorry, I am not familiar with git, do not know how to change the comment of a commit, or delete a commit, so, commit the 2nd. how about this: I abort this Pull Request, and create a new Pull Request, I will take careful with the commit comment.

legionus commented 1 year ago

sorry, I am not familiar with git, do not know how to change the comment of a commit, or delete a commit, so, commit the 2nd. how about this: I abort this Pull Request, and create a new Pull Request, I will take careful with the commit comment.

Ok. I will do it by myself.

stzdzyhs commented 1 year ago

Thank you!

legionus commented 1 year ago

Merged.