Closed Meriipu closed 4 years ago
I do not think I know how to make the tests pass, then. (if these are even desirable changes to include)
I do not feel any particular sense of "ownership" of the patch (particularly since it just copies over the new symbols), so if somebody else feels like potentially modifying it I would not mind.
This PR is wrong because it breaks backward compatibility. You removed the synonyms and it will break the keymaps that use these synonyms. @dmage made a commit that doesn't break compatibility based on your PR: https://github.com/legionus/kbd/commit/df4de8f1245fab5395e6ee7ce0ce533c21703366
Thanks
see also https://github.com/legionus/kbd/issues/43
Are these changes possibly too compatibility-breaking to be merged, e.g. if somebody relies on the aliases/compose-lines for 4 of the existing ones (under the comment about not being implemented yet)? I am also not sure what the entries in the
trans_names
-table indata/keymaps/i386/mk_modmap
are for (they appear to be 1:1 for the dead_keys).