Update la-latin1.map - Githubissues

legionus / kbd

Mirror of https://git.kernel.org/pub/scm/linux/kernel/git/legion/kbd.git

https://kbd-project.org

Other

84 stars 41 forks source link

Update la-latin1.map #83

Closed mbfarah closed 2 years ago

mbfarah commented 2 years ago

Corrected the layout, according to the Spanish (Latin America) layout specification.

The corner alpha now produces the degree sign instead of the ordinal masculine sign.
Added the missing dead keys for the grave and circumflex accents.
All four diacritic dead keys take all vowels; the acute accent and the diaeresis also accept the letter Y.

See https://www.farah.cl/Keyboardery/A-Visual-Comparison-of-Different-National-Layouts/#esLA for further reference.

Signed-off-by: Miguel Farah miguel@farah.cl

legionus commented 2 years ago

Please add Signed-off-by.

https://github.com/legionus/kbd/blob/master/docs/process/howto-contribute.md#sending-patches=

mbfarah commented 2 years ago

Please add Signed-off-by.

Done. Sorry for the omission.

legionus commented 2 years ago

Please add Signed-off-by.

Done. Sorry for the omission.

You added it to the PR description. What I meant was that Signed-off-by should be in the commit [1]. You can easily add it with git commit -s --amend and push it again.

[1] https://patch-diff.githubusercontent.com/raw/legionus/kbd/pull/83.patch

mbfarah commented 2 years ago

I couldn't do the amend with an open pull request; everything should be fine and dandy now.

legionus commented 2 years ago

I did not understand why you closed the PR and why you didn't push the signed commit.

mbfarah commented 2 years ago

Gosh darn it to heck. I closed the PR because neither Github.com nor Github Desktop would allow me to do the amend with it open... and when I reopened it, the push for the signed commit didn't go through. Serves me right for trusting something other than the command line. I'll just try this again on a new PR.