search

legoandmars / BiggerLobby

Functional version of kermeet's biglobby mod.
MIT License
15 stars 4 forks source link

Suits spawning in incorrect location for clients #1

Closed legoandmars closed 11 months ago

legoandmars commented 11 months ago

Think this is a regression from changes made after 2.2.60

legoandmars commented 11 months ago

This may be causing more sync issues when players have suits equipped (or unlocked) not sure - LC Modding Discord Context

Error while syncing unlockables in server. Quitting server: System.IndexOutOfRangeException: Index was outside the bounds of the array. at (wrapper dynamic-method) StartOfRound.DMD<StartOfRound::SyncShipUnlockablesServerRpc>(StartOfRound)

legoandmars commented 11 months ago

Also sometimes throws on the ClientRPC when the player is the server

Error while syncing unlockables in server. Quitting server: System.IndexOutOfRangeException: Index was outside the bounds of the array. at BiggerLobby.Patches.PlayerObjects.SyncShipUnlockablesClientRpc (StartOfRound __instance, System.Int32[] playerSuitIDs, System.Boolean shipLightsOn, UnityEngine.Vector3[] placeableObjectPositions, UnityEngine.Vector3[] placeableObjectRotations, System.Int32[] placeableObjects, System.Int32[] storedItems, System.Int32[] scrapValues, System.Int32[] itemSaveData) [0x00032] in <280ffa0e905b40a1a5f966e90e149aac>:0

legoandmars commented 11 months ago

Probably a race condition caused by not setting MaxPlayers soon enough

legoandmars commented 11 months ago

should be fixed in 2.4.0, if anybody continues to have sync/object problems please post your BepInEx/LogOutput.log here