Closed Qendolin closed 2 years ago
I still need to do one last test, which is creating a dummy mod and adding ConnectibleChains compatibility to it
It works! Ready for review.
java/net/fabricmc/example/ExampleMod.java
if(FabricLoader.getInstance().isModLoaded("connectiblechains")) {
ChainTypesRegistry.register(Items.DIRT);
}
resources/assets/minecraft/models/entity/chain/dirt.json
{
"textures": {
"chain": "minecraft:textures/block/dirt",
"knot": "minecraft:textures/block/dirt"
}
}
There might be an issue with resource priority where f.e. valley craft cannot override the default copper_chain model because it has a lesser priority. I haven't encountered this issue in my testing but I don't see why it cannot happen. I'll have to do some changes to how builtin types are loaded.
Using structure blocks to move chains has weird side effects - seemingly only chains which share the same X axis are stored properly. Screenshots attached below.
That is very interesting, since I already had that exact same issue and fixed it. But now it's back. Removing that line only works when no mirror is applied.
I've tested all possible combinations of mirroring and rotation, this should work now.
"No longer use log4j as there are now other ones that fabric wants you to use.". Do you mean slf4j? I'm not sure if that is available before 1.18.2
"No longer use log4j as there are now other ones that fabric wants you to use.". Do you mean slf4j? I'm not sure if that is available before 1.18.2
Does this mean that the current code does not work in 1.18.2? Or can I publish this new version?