legoatoom / ConnectibleChains

Connect your fences with a decorative chain!
GNU Lesser General Public License v3.0
14 stars 6 forks source link

Chains invisible when rejoining a server #47

Closed Jacksteroonie closed 3 months ago

Jacksteroonie commented 1 year ago

Whenever I rejoin a server in which I have placed the connectible chains, they are invisible. They can still be interacted with, preventing movement and are able to be cut with shears. The chain wrapped around the fence is still visible. The chain spanning between the fences is invisible.

legoatoom commented 1 year ago

Could you provide a step by step guide for me to reproduce the bug?

DudBoii123 commented 1 year ago

Could you provide a step by step guide for me to reproduce the bug?

all you have to do is play on a multiplayer server, connect two fences (say 4 blocks apart) with a chain, leave the server, and rejoin. Sometimes it takes leaving/joining 2 or 3 times, but it always happens eventually.

legoatoom commented 1 year ago

I will take a look at it when I have time.

genorfake commented 1 year ago

I will take a look at it when I have time.

hi, legoatoom. it seems like this bug happens in single player worlds too. placing new chains on fences and rejoining fixes the bugged chains and makes the new chains invisible. here are the steps i took to do the bug: place 2 fences with any distance between and put a chain on them. rejoin the world and you got invisible chains. this issue also may have to do something with sodium or the simply optimized modpack im not sure though

FAKHORII commented 11 months ago

I will take a look at it when I have time.

hi, legoatoom. it seems like this bug happens in single player worlds too. placing new chains on fences and rejoining fixes the bugged chains and makes the new chains invisible. here are the steps i took to do the bug: place 2 fences with any distance between and put a chain on them. rejoin the world and you got invisible chains. this issue also may have to do something with sodium or the simply optimized modpack im not sure though

same with me, u just join ur world and u find it invisible, simple as that

Dbl7id commented 11 months ago

Possible this was due to an older version of sodium. Updating to the latest version should remove this issue entirely.

legoatoom commented 11 months ago

If this issue remains, please let me know.

FAKHORII commented 11 months ago

I believe it happens only if u are in range with the chains, if u go far where they don't render usually and come closer again then they will appear, but hey! why the range of rendering the chains is sooo short anyway?? I made a bridge that is a somewhat of a couple of chunks and the chains wont render further like!... it doesn't make things look good! plus it drops the fps like crazy

legoatoom commented 11 months ago

I believe it happens only if u are in range with the chains, if u go far where they don't render usually and come closer again then they will appear, but hey! why the range of rendering the chains is sooo short anyway?? I made a bridge that is a somewhat of a couple of chunks and the chains wont render further like!... it doesn't make things look good! plus it drops the fps like crazy

I can make the range increase, that is something I will do for the next update. So you also have issues like #52?

FAKHORII commented 11 months ago

I believe it happens only if u are in range with the chains, if u go far where they don't render usually and come closer again then they will appear, but hey! why the range of rendering the chains is sooo short anyway?? I made a bridge that is a somewhat of a couple of chunks and the chains wont render further like!... it doesn't make things look good! plus it drops the fps like crazy

I can make the range increase, that is something I will do for the next update. So you also have issues like #52?

I really cant tell, all I know I made a long bridge.. something like 40 blocks with chains in 2 sides and it drops fps by a lot as if there are a hundred entity in front of me... idk anything about such stuff, but cant the chains just act like normal blocks somehow! instead of like entities... anyways, ty for ur care and also for increasing the range of the render, appreciate u <3

legoatoom commented 11 months ago

Do you have chains that are 40 blocks long? The default is set to 7 for a reason. 40 blocks will create a lot of collision entities.

Learwin commented 10 months ago

I also get the issue that chains disappear on world reload. Not always but I would say 50/50. grafik

Going away for like 30-50 blocks and returning makes them show up again. grafik

In addition I noticed that this appears in the console

[16:09:43] [Render thread/WARN] [ConnectibleChains/]: Tried to attach from null (#2086) which is not chain knot
[16:09:43] [Render thread/WARN] [ConnectibleChains/]: Tried to attach from null (#2105) which is not chain knot
[16:09:43] [Render thread/WARN] [ConnectibleChains/]: Tried to attach from null (#2131) which is not chain knot
legoatoom commented 5 months ago

I have done some changes to the networking in 1.20.4 Please keep me up to date if it still happens.

Leobizaz commented 5 months ago

Hello! The invisible chains issue still persists on 1.20.1 I'm running on the latest (as of now) 1.20.1 Sodium 0.5.8

I also get these from the logs:

[00:29:55] [Render thread/WARN]: Tried to attach from null (#2100) which is not chain knot
[00:29:55] [Render thread/WARN]: Tried to attach from null (#2102) which is not chain knot
[00:29:55] [Render thread/WARN]: Tried to attach from null (#2104) which is not chain knot
[00:29:55] [Render thread/WARN]: Tried to attach from null (#2105) which is not chain knot
[00:29:55] [Render thread/WARN]: Tried to attach from null (#2107) which is not chain knot

Is it possible to fix this for this version?

Leobizaz commented 5 months ago

Also, weirdly enough after respawning (on singleplayer) the chains loaded back up normally.

legoatoom commented 5 months ago

Yes the problem is simple, the info to attach a chain from point a to point b arrives before the client knows about point a. Thus when I try to get the entity from an ID the client is like, "i dunno what that entity is" and returns null.

Can you check if the problem still exists in 1.20.4 because I tried to fix this exact problem then.

legoatoom commented 3 months ago

Due to inactivity, this issue is assumed to be fixed.