search

legoatoom / ConnectibleChains

Connect your fences with a decorative chain!
GNU Lesser General Public License v3.0
14 stars 6 forks source link

[Version Request] 1.20.4 update #55

Closed vico93 closed 8 months ago

vico93 commented 10 months ago

Is a 1.20.4+ update in the radar?

Cactuxfrombrazil commented 8 months ago

I want one too

vico93 commented 8 months ago

Forgot to update this issue, @DerpDerpling kindly did at my request a fork of this mod to 1.20.4:

https://github.com/DerpDerpling/ConnectibleChains/tree/1.20.4

I tested and seems to not trigger any errors. I think a release would be done!

DerpDerpling commented 8 months ago

I did have to remove some stuff from that port, so it may be a bit buggy

legoatoom commented 8 months ago

I am looking into updating it but I am the network changes made by the fabric api make it difficult.

From the blog to 1.20.2 (https://fabricmc.net/2023/09/12/1202.html)

There is one breaking change to Networking API: ClientPlayNetworking#createC2SPacket now returns Packet instead of Packet (and similar changes with createS2CPacket as well.)

I looked at the source code from @DerpDerpling to see what their attempt at fixing this was. But I do not understand how they have done it, renaming the createSpawnPacket() function in the entity seems weird. As that function is normally called when a new entity is created.

Further info: https://gist.github.com/apple502j/9c6b9e5e8dec37cbf6f3916472a79d57

It seems the networking has changed a lot and I need to do a lot of work replacing it.

legoatoom commented 8 months ago

I have implemented some of the new networking changes and it seems to work. I will do some more testing when I have time, hopefully this weekend. If all works, then I will release the update. When 1.21 is released I hope that time the wait isn't that long.