legokichi / ts-ebml

EBML encoder and decoder
177 stars 52 forks source link

new maintainer #21

Open legokichi opened 5 years ago

legokichi commented 5 years ago

i dont have enough time to maintain this repository anybody help?

guest271314 commented 5 years ago

Willing to help where able.

marob commented 2 years ago

@guest271314 I see you're pretty active on this unmaintained package. Would you consider becoming the new maintainer?

You could ask @legokichi some contributor role on his repository and becoming owner of the package on npmjs repository, or decide to publish your fork as a new package that would become the de facto maintained version of this package.

I'm particularly interested by having a JavaScript module version of this package in order to be able to use it in slidev: https://github.com/slidevjs/slidev/pull/491

guest271314 commented 2 years ago

I am not familiar with TypeScript. I am willing to help where I can.

You should just be able to use the Ecmascript module version of ts-ebml. I also created an exportable version of lamejs for https://github.com/guest271314/captureSystemAudio/tree/master/native_messaging/capture_system_audio.

marob commented 2 years ago

The goal is indeed to be able to use the Ecmascript module version of ts-ebml in slidev (https://github.com/slidevjs/slidev/pull/491). But in order to be able to do that, we need to have this Ecmascript module version available somewhere in an npm package. If I'm not mistaking, Ecmascript module version is not available in ts-ebml npm package (as it's only in your fork sources), nor in any other npm package.

I did find the Ecmascript module version:

guest271314 commented 2 years ago

I have only worked on 1 npm package. What I suggest is just using the minimized Ecmascript module version.

we need to have this Ecmascript module version available somewhere in an npm package

Why?

All of the necessay code is in the single script.

          const {
            Decoder,
            Encoder,
            tools,
            Reader,
            injectMetadata,
          } = await import(`${this.src.origin}/ts-ebml.min.js`);
marob commented 2 years ago

we need to have this Ecmascript module version available somewhere in an npm package

Why?

Because using dependency management is good practice. If we depend on some JavaScript available at some URL at runtime, it can fail if it's unavailable, if the user is not connected, ... If we duplicate the JavaScript code in slidev, we'll never benefit from any update/fix of the original ts-ebml.

That's why we need the Ecmascript module version in a published npm package on the npmjs registry.

guest271314 commented 2 years ago

@marob

You could ask @legokichi some contributor role on his repository and becoming owner of the package on npmjs repository, or decide to publish your fork as a new package that would become the de facto maintained version of this package.

I am willing to help where able, particularly with testing. I have no experience with TypeScript. Are you committed to maintain the TypeScript in this repository?

@davedoesdev the owner of https://github.com/davedoesdev/webm-muxer.js which also uses https://github.com/muaz-khan/RecordRTC/blob/master/libs/EBML.js could also be a potential candidate for maintainer.

marob commented 2 years ago

@guest271314 I just need this package as a dependency and have no expertise in video manipulation. Also, I haven't read the code of ts-ebml. I don't see myself maintaining this package.

TypeScript is everywhere today in JS world. You should give it a try :wink:

So, we still don't have a solution for now...

Maybe @muaz-khan could also be a candidate as maintainer of ts-ebml as it's used in https://github.com/muaz-khan/RecordRTC? In addition, RecordRTC is the package used in slidev and is the one that should depend on ts-ebml in my opinion.

guest271314 commented 2 years ago

@marob Can't you just merge the PR I filed into your fork and publish your fork on npm?

marob commented 2 years ago

@guest271314 I could, but then we would have 2 unmaintained packages.

davedoesdev commented 2 years ago

I can help out, can't promise super quick turnaround though.

marob commented 2 years ago

Hi @davedoesdev. How can you help? Are you ready to maintain a fork of this repository?