search

legumeinfo / ArachisPheno

AraPheno source code for http://arapheno.1001genomes.org
MIT License
0 stars 0 forks source link

Fix # Values column #21

Closed svengato closed 3 years ago

svengato commented 3 years ago

Missing or incorrect in the study-phenotype table, the accession-phenotype table, and also the REST API.

This problem existed in AraPheno, so do a pull request once fixed.

svengato commented 3 years ago

The definition of num_values in those table constructors was missing or incorrect, but I fixed them. "# Values" should now be correct in all phenotype tables: study detail, accession detail, and the phenotype list (which was already correct).

Next: figure out what is missing in the REST API.

svengato commented 3 years ago

Checked in the corrections to the phenotype tables, and submitted a (minimal) pull request to AraPheno.

Considering whether to move the REST API questions to a separate issue.

svengato commented 3 years ago

AraPheno accepted the pull request.

svengato commented 3 years ago

Moved REST API questions to issue #22.