search

legumeinfo / ArachisPheno

AraPheno source code for http://arapheno.1001genomes.org
MIT License
0 stars 0 forks source link

Fix REST API #22

Closed svengato closed 3 years ago

svengato commented 3 years ago

These bugs are all present in the original AraPheno. There may be others.

  1. Phenotype lists: fields like num_values are often missing.
  2. Do num_values and number_replicates mean the same thing? If so, we could eliminate the latter.
  3. Phenotype lists use AraPheno's DOI (10.21958), as defined in arapheno/arapheno/settings/defaults.py. Do we have our own DOI?
  4. Missing commas between ontology types in the header. (This is a simple oversight in arapheno/phenotypedb/renderer.py, easy to fix).

Another alternative is to hide the REST API for now.

(split off from issue #21)

svengato commented 3 years ago

Bugs 1, 2, and 4 are now fixed.

  1. The REST API FAQ page lists a couple of example accessions. I chose PI 497318 and PI 497395 as they are both from the same country (Bolivia, chosen at random) and visible on the map. Let me know if you prefer a different pair of accessions.
svengato commented 3 years ago

Also submitted a pull request to AraPheno (only for the num_values columns and the missing commas).

(Pull request was accepted.)