search

legumeinfo / ZZBrowse

Other
1 stars 1 forks source link

Provision for Single Dataset View #38

Closed sdash-github closed 2 years ago

sdash-github commented 2 years ago

Sometimes it is desirable to look at a single dataset without having to compare to another dataset. If possible and makes sense, making provisions for hiding/showing a panel, so that only needded panels are displayed.

svengato commented 2 years ago

I added a "Two Species" switch at the top left of the Manage tab. This toggles species 2, Swap Datasets, genomic linkage, and macrosynteny.

Known issues:

svengato commented 2 years ago

It should also update to/from the URL (to do: add a twoSpecies=[y|n] field).

svengato commented 2 years ago

It now updates to and from the URL, for example you can input something like

http://dev.lis.ncgr.org:50071/ZZBrowse/?tab=Manage&species=1&datasets=Peanut%20GWAS&chr=Arahy.01&selected=100000&window=250000

The species (= 1 or 2) tag is optional, if missing it implies that ZZBrowse should display both species. Let me know if this does not work as expected.

sdash-github commented 2 years ago

I just tested and it behaves as you described. An observation: I revised to species=2 from species=1 and it did displayed both species panels and in the URL the parameter '&species=' disappeared. It doesn't affect what I want to see in these panels but just wanted to alert you that this is happening as intended. I am not worried about it at all now.

Thanks for getting it done in time.

Sudhansu

On 11/27/21 8:27 PM, svengato wrote:

It now updates to and from the URL, for example you can input something like

http://dev.lis.ncgr.org:50071/ZZBrowse/?tab=Manage&species=1&datasets=Peanut%20GWAS&chr=Arahy.01&selected=100000&window=250000 http://dev.lis.ncgr.org:50071/ZZBrowse/?tab=Manage&species=1&datasets=Peanut%20GWAS&chr=Arahy.01&selected=100000&window=250000

The species (= 1 or 2) tag is optional, if missing it implies that ZZBrowse should display both species. Let me know if this does not work as expected.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/legumeinfo/ZZBrowse/issues/38#issuecomment-980824660, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4A465LSH5W3TBG2JZ2SEDUOGHQ5ANCNFSM5HS5KX3A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

svengato commented 2 years ago

An observation: I revised to species=2 from species=1 and it did displayed both species panels and in the URL the parameter '&species=' disappeared. It doesn't affect what I want to see in these panels but just wanted to alert you that this is happening as intended. I am not worried about it at all now.

Great - let me know if you prefer to always see the "species=" tag, it is easy enough to change that.

Also, would "twoSpecies=y/n" be less confusing than "species=1/2"? Someone might try "species=peanut", for example.

sdash-github commented 2 years ago

I like "twoSpecies=y/n". But like said this is not urgent at all-- do it if you want to. The primary need has already been achieved y you, one or two species panels.

Sudhansu

On 11/27/21 9:27 PM, svengato wrote:

An observation: I revised to species=2 from species=1 and it did displayed both species panels and in the URL the parameter '&species=' disappeared. It doesn't affect what I want to see in these panels but just wanted to alert you that this is happening as intended. I am not worried about it at all now.

Great - let me know if you prefer to always see the "species=" tag, it is easy enough to change that.

Also, would "twoSpecies=y/n" be less confusing than "species=1/2"? Someone might try "species=peanut", for example.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/legumeinfo/ZZBrowse/issues/38#issuecomment-980830607, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4A467I7347YRL6MUEDABDUOGOTLANCNFSM5HS5KX3A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

svengato commented 2 years ago

I like "twoSpecies=y/n". But like said this is not urgent at all-- do it if you want to. The primary need has already been achieved y you, one or two species panels.

Done. Try

http://dev.lis.ncgr.org:50071/ZZBrowse/?tab=Manage&twoSpecies=n&datasets=Peanut%20GWAS&chr=Vr01&selected=100000&window=250000

or toggling the Two Species checkbox by hand.

svengato commented 2 years ago

Known issue: when Two Species is turned off, the Genomic Linkage button still appears in the linkouts dialog, which is not aware of the checkbox state - could be tricky to fix.

svengato commented 2 years ago

Added in commit 61abf99.

svengato commented 2 years ago

Known issue: when Two Species is turned off, the Genomic Linkage button still appears in the linkouts dialog, which is not aware of the checkbox state - could be tricky to fix.

Fixed in commit d6be90e.