legumeinfo / datastore-issues

mostly for issues pertaining to the content of the legumeinfo datastore; may also relate to characteristics of its user interface or managing the mirroring process to the legfed instance
Other
1 stars 0 forks source link

Annotation GFFs with duplicate ID records #153

Closed sammyjava closed 1 year ago

sammyjava commented 1 year ago

OK, I'm consolidating this issue into one since there are a lot of these GFFs with duplicate IDs. Fix 'em and check 'em off!

StevenCannon-USDA commented 1 year ago

Fwiw, I am planning to start on these tomorrow (Groundhog Day; hope that doesn't augur ill)

adf-ncgr commented 1 year ago

OK, I think these should now be handled. One potential remaining issue is with Zh13.gnm2.ann1 which has some gene features that have the same ID value as child miRNA_primary_transcript features. I think it doesn't bother intermine if IDs are the same, as long as they are associated with objects of different types; but it might still bother someone. In any case, let me know if any loading issues remain with any of these.

sammyjava commented 1 year ago

Correct, in fact we typically have proteins and transcripts with the same ID (from different files, but mine loaders don't care about that). It's object.class + object.primaryIdentifer that must be unique (for Annotatables).

sammyjava commented 1 year ago

sigh I'll list 'em one by one in following comments.

sammyjava commented 1 year ago

[shokin@lis ~]$ validate-annotation-collection v2/Vigna/angularis/annotations/Gyeongwon.gnm3.ann1.3Nz5/

Validating vigan collection Gyeongwon.gnm3.ann1.3Nz5

sammyjava commented 1 year ago

Different issue but I'll put it here since we're trying to get these annotation collections to validate.

Validating arahy collection Tifrunner.gnm2.ann1.4K0L

sammyjava commented 1 year ago

OK, that's it, seven out of nine isn't too bad.

adf-ncgr commented 1 year ago

OK, the issue with Gyeongwon.gnm3.ann1 should be fixed, I'd not realized on the first one that some non-CDS features were sometimes at issue as well. Will look into the remaining gfa issues, but not immediately.

sammyjava commented 1 year ago

I expect it can be any type. It validates, thanks! I'll close this since we do have the specific issue on the GFA non-conformity.