search

legumeinfo / gcv

Federating genomes with love (and synteny derived from functional annotations)
https://gcv.legumeinfo.org/
Apache License 2.0
38 stars 12 forks source link

Data download only returning partial data #196

Closed alancleary closed 5 years ago

alancleary commented 5 years ago

Currently the GCV implements its data flow via mixins, that is, rather than replicating immutable objects to add additional attributes to, it uses the immutable objects as the prototype for new, mutable objects which the new attributes can be added to. Unfortunately, the data download mechanism only returns the attributes of the bottom object in this prototype chain, so, for example, only the x and y attributes added by the micro-synteny viewer are available for download. Fix this! For now, just make sure all the attributes are returned.

alancleary commented 5 years ago

Fixed in commit 3af3853e3cd2a0023e6799a6788f1a637fb5fa59, though now attributes that users may not be interested in are also being output, e.g. htmlAttributes.