search

legumeinfo / graphql-server

A GraphQL server that supports the Legume Information System and related biodata websites
Apache License 2.0
2 stars 3 forks source link

Results count #149

Closed alancleary closed 6 months ago

alancleary commented 6 months ago

This PR adds a pathQueryCount method to the InterMine data source and uses it to compute pagination info for queries in place of the finicky summaryPath queries.

I haven't been able to thoroughly test this but I've confirmed it works on all queries that our Web Components are using.

alancleary commented 6 months ago

I've glanced over it, looks like the meat of the change was in src/data-sources/intermine/intermine.server.ts and the rest was just updating all the code that was affected, monotonously. I am happy to trust that your testing was more thorough than mine likely would be. But let me know if there's anything in particular you wanted me to look over.

My testing was pretty brief this time around. It compiles and runs, and the queries the Web Components rely on are working, so let's go ahead and merge. FYI the coding wasn't too bad. I used sed to do most of the refactoring ;)